On Thu, Oct 06, 2022 at 03:36:57PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > This has been tested under msys2 & windows 11. I haven't tried to make > it work with other environments yet, but that should be enough to > validate the channel-command implementation anyway. > > Here are the changes: > - drop tests/ from fifo/pipe path, to avoid directory issues > - use g_find_program() to lookup the socat executable (otherwise we > would need to change ChanneCommand to use G_SPAWN_SEARCH_PATH, and deal > with missing socat differently) > - skip the "echo" test when socat is missing as well > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > tests/unit/test-io-channel-command.c | 37 ++++++++++++++-------------- > 1 file changed, 19 insertions(+), 18 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
