On Mittwoch, 12. Oktober 2022 17:17:46 CEST Bin Meng wrote: > Hi, > > On Wed, Oct 12, 2022 at 8:32 PM Nikita Ivanov <niva...@cloudlinux.com> wrote: > > There is a defined RETRY_ON_EINTR() macro in qemu/osdep.h which > > handles the same while loop. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/415 > > > > Signed-off-by: Nikita Ivanov <niva...@cloudlinux.com> > > --- > > > > block/file-posix.c | 37 ++++++++++++++++--------------------- > > chardev/char-pty.c | 4 +--- > > hw/9pfs/9p-local.c | 8 ++------ > > net/l2tpv3.c | 17 +++++------------ > > net/socket.c | 16 +++++++--------- > > net/tap.c | 12 ++++-------- > > qga/commands-posix.c | 4 +--- > > semihosting/syscalls.c | 4 +--- > > tests/qtest/libqtest.c | 14 ++++++-------- > > tests/vhost-user-bridge.c | 4 +--- > > util/main-loop.c | 4 +--- > > util/osdep.c | 4 +--- > > util/vfio-helpers.c | 12 ++++++------ > > 13 files changed, 52 insertions(+), 88 deletions(-) > > This patch has to be squashed into patch 1 for bisectability, as TFR > is already removed in patch 1.
They are intentionally separated: 1st patch replaces occurrences of TFR, whereas 2nd patch introduces use of macro at locations where not used yet. Nikita, could you please move those 2 hunks that still had TFR() occurrence to patch 1? And please use git's --thread option next time, so that individual patch emails are linked to cover letter email (which adds appropriate `References:` and `In-Reply-To:` email headers). Best regards, Christian Schoenebeck
