On 01/02/2012 11:58 PM, Richard Henderson wrote: > On 01/03/2012 03:33 AM, Avi Kivity wrote: > > - if ((pd & ~TARGET_PAGE_MASK) > IO_MEM_ROM && !(pd & IO_MEM_ROMD)) { > > + if (!is_ram_rom(pd) && !(pd & IO_MEM_ROMD)) { > > /* IO memory case (romd handled later) */ > > Perhaps (!is_ram_rom_romd(pd))?
Yeah, will change. > At least that's what I see from DeMorgan's, even though it > doesn't quite seem to tally with the comment... The comment actually fits both (!is_ram_rom && !is_romd()) and (!is_ram_rom && is_romd()), since romd acts like both rom and I/O memory. The code appears to be correct. -- error compiling committee.c: too many arguments to function