On Mon, 17 Oct 2022 at 21:57, Philippe Mathieu-Daudé <phi...@linaro.org> wrote: > > On 16/10/22 14:27, Bernhard Beschow wrote: > > pflash_cfi01_register() always returns with a non-NULL pointer (otherwise > > it would crash internally). Therefore, the bodies of the if-statements > > are unreachable. > > This is true, pflash_cfi0X_register() use an hardcoded &error_fatal. > > Shouldn't it be better to pass an Error* argument?
The whole function is a legacy convenience-wrapper that's just doing "create, configure, realize and wire up a device". New code, and any callers that actually care about errors, should just be directly creating and configuring the device anyway. Almost all the callers are in old legacy board model code. -- PMM
