On 10/19/22 14:37, Philippe Mathieu-Daudé wrote:
On 19/10/22 21:15, Christian A. Ehrhardt wrote:Fix memset argument order: The second argument is the value, the length goes last. Cc: Eric DeVolder <eric.devol...@oracle.com> Cc: qemu-sta...@nongnu.org Fixes: f7e26ffa590 ("ACPI ERST: support for ACPI ERST feature") Signed-off-by: Christian A. Ehrhardt <l...@c--e.de> --- hw/acpi/erst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/acpi/erst.c b/hw/acpi/erst.c index df856b2669..26391f93ca 100644 --- a/hw/acpi/erst.c +++ b/hw/acpi/erst.c @@ -716,7 +716,7 @@ static unsigned write_erst_record(ERSTDeviceState *s) if (nvram) { /* Write the record into the slot */ memcpy(nvram, exchange, record_length); - memset(nvram + record_length, exchange_length - record_length, 0xFF); + memset(nvram + record_length, 0xFF, exchange_length - record_length);Ouch
Sheesh, I'd hate to be that guy... Reviewed-by: Eric DeVolder <eric.devol...@oracle.com>
Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
