Understood, thank you a lot :) Best regards Timofey
On Thu, Oct 27, 2022 at 12:35 PM Peter Maydell <peter.mayd...@linaro.org> wrote: > On Thu, 27 Oct 2022 at 10:22, Timofey Kutergin <tkuter...@gmail.com> > wrote: > > > V8 always implies V7, so we only need to check V7 here. > > > From silicon perspective - yes, but as I see in qemu, > > ARM_FEATURE_V7 and ARM_FEATURE_V8 are independent bits which do not > affect each > > other in arm_feature() and set_feature() so they should be tested > separately. > > Did I miss something? > > In arm_cpu_realizefn() there is code which sets feature flags > that are always implied by other feature flags. There we set > the V7VE flag if V8 is set, and the V7 flag if V7VE is set. > So we can rely on any v8 CPU having the V7 feature flag set. > > thanks > -- PMM >