On 11/1/22 19:29, Philippe Mathieu-Daudé wrote:
This is a respin of Bernhard's v4 with Freescale eSDHC implemented as an 'UNIMP' region. See v4 cover here: https://lore.kernel.org/qemu-devel/20221018210146.193159-1-shen...@gmail.com/ Since v5: - Rebased (ppc-next merged) - Properly handle big-endian Since v4: - Do not rename ESDHC_* definitions to USDHC_* - Do not modify SDHCIState structure Supersedes: <20221031115402.91912-1-phi...@linaro.org>
Queued in gitlab.com/danielhb/qemu/tree/ppc-8.0 (since we missed the freeze for 7.2). BTW, checkpatch complained about this line being too long (83 chars): 3/3 Checking commit bc7b8cc88560 (hw/ppc/e500: Add Freescale eSDHC to e500plat) WARNING: line over 80 characters #150: FILE: hw/ppc/e500.c:1024: + pmc->ccsrbar_base + MPC85XX_ESDHC_REGS_OFFSET, The code except is this: if (pmc->has_esdhc) { create_unimplemented_device("esdhc", pmc->ccsrbar_base + MPC85XX_ESDHC_REGS_OFFSET, MPC85XX_ESDHC_REGS_SIZE); To get rid of the warning we would need to make a python-esque identation (line break after "(" ) or create a new variable to hold the sum. Both seems overkill so I'll ignore the warning. Phil is welcome to re-send if he thinks it's worth it. And I'll follow it up with my usual plea in these cases: can we move the line size warning to 100 chars? For QEMU 8.0? Pretty please? Daniel
Philippe Mathieu-Daudé (3): hw/sd/sdhci: MMIO region is implemented in 32-bit accesses hw/sd/sdhci: Support big endian SD host controller interfaces hw/ppc/e500: Add Freescale eSDHC to e500plat docs/system/ppc/ppce500.rst | 13 ++++++++++ hw/ppc/Kconfig | 2 ++ hw/ppc/e500.c | 48 ++++++++++++++++++++++++++++++++++++- hw/ppc/e500.h | 1 + hw/ppc/e500plat.c | 1 + hw/sd/sdhci-internal.h | 1 + hw/sd/sdhci.c | 36 +++++++++++++++++++++++++--- include/hw/sd/sdhci.h | 1 + 8 files changed, 99 insertions(+), 4 deletions(-)