On 11/8/22 21:36, Vladimir Sementsov-Ogievskiy wrote:
On 11/3/22 19:16, Avihai Horon wrote:
From: Juan Quintela <quint...@redhat.com>
And it appears that what is wrong is the code. During bulk stage we
need to make sure that some block is dirty, but no games with
max_size at all.
:) That made me interested in, why we need this one block, so I decided to
search through the history.
And what I see? Haha, that was my commit 04636dc410b163c "migration/block: fix
pending() return value" [1], which you actually revert with this patch.
So, at least we should note, that it's a revert of [1].
Still that this will reintroduce the bug fixed by [1].
As I understand the problem is (was) that in block_save_complete() we finalize
only dirty blocks, but don't finalize the bulk phase if it's not finalized yet.
So, we can fix block_save_complete() to finalize the bulk phase, instead of
hacking with pending in [1].
Interesting, why we need this one block, described in the comment you refer to?
Was it an incomplete workaround for the same problem, described in [1]? If so,
we can fix block_save_complete() and remove this if() together with the comment
from block_save_pending().
PS: Don't we want to deprecate block migration? Is it really used in
production? block-mirror is a recommended way to migrate block devices.
--
Best regards,
Vladimir
