On 8/11/22 23:11, Palmer Dabbelt wrote:
On Sat, 05 Nov 2022 04:53:29 PDT (-0700), m...@tls.msk.ru wrote:
Fixes: 0694dabe9763847f3010b54ab3ec7d367d2f0ff0
Not sure if I missed something in QEMU land, but those are usually
listed more like
Fixes: 0694dabe97 ("hw/ssi: Add SiFive SPI controller support")
MST suggested once to try to restrict the 'Fixes:' tag to bug /
regressions, as it might help downstream distributions to filter
commits to cherry-pick.
Since it might be useful to have the offending commit sha1 in the
description, when it is simply an omission or improvement I use
the an inline form instead of a tag:
Fixes the typo introduced in commit 0694dabe97 ("hw/ssi: Add SiFive
SPI controller support").
Although in this particular use-case it is not really useful ;)
Another example:
When adding <the feature> in commit <sha1 ("<subject>")>, we forgot
to fill the API prototype description. Do it now.
Regards,
Phil.
