On 11/12/22 04:25, Alex Bennée wrote:
+ switch (attrs.requester_type) {
+ case MTRT_MACHINE: /* MEMTX_IOPIC */
Not checking the id?
+ case MTRT_PCI: /* PCI signalled MSI */ + break; + default: + qemu_log_mask(LOG_GUEST_ERROR, "%s: rejecting write from %d", + __func__, attrs.requester_id); + return MEMTX_ACCESS_ERROR; + }
Logging the requester_id by itself isn't great -- you need the type to know what you're looking at.
Otherwise, Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~
