On Mon, Jan 02, 2012 at 06:52:15PM -0600, Anthony Liguori wrote: > I have no idea what's going on here, but this is broken and cannot possibly > work because: > > 1) It's qdev name conflicts with a device that sits on SysBus > > 2) The PCI constructor expects a SysBus device... but's it's a PCIDevice > > If you do qdev_create("grackle"), the code expects to get the SysBus version > so drop the mystery PCI version. > > Signed-off-by: Anthony Liguori <aligu...@us.ibm.com> > --- > hw/grackle_pci.c | 17 ----------------- > 1 files changed, 0 insertions(+), 17 deletions(-)
NACK. Maybe the current code is not correct, but it actually works, and a PCI host device like this one is definitely needed on the system. Trying to apply this patch, qemu-system-ppc fails to start with: qemu: hardware error: Unknown device 'grackle' for bus 'PCI' -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurel...@aurel32.net http://www.aurel32.net