> -----Original Message----- > From: Daniel P. Berrangé <berra...@redhat.com> > Sent: 15 November 2022 19:47 > To: Or Ozeri <o...@il.ibm.com> > Cc: qemu-devel@nongnu.org; qemu-bl...@nongnu.org; Danny Harnik > <dan...@il.ibm.com>; idryo...@gmail.com > Subject: [EXTERNAL] Re: [PATCH v3] block/rbd: Add support for layered > encryption > > AFAICT, supporting layered encryption shouldn't require anything other than > the 'parent' addition. >
Since the layered encryption API is new in librbd, we don't have to support "luks" and "luks2" at all. In librbd we are actually deprecating the use of "luks" and "luks2", and instead ask users to use "luks-any". If we don't add "luks-any" here, we will need to implement explicit cases for "luks" and "luks2" in the qemu_rbd_encryption_load2. This looks like a kind of wasteful coding that won't be actually used by users of the rbd driver in qemu. Anyhow, we need the "luks-any" option for our use-case, so if you insist, I will first submit a patch to add "luks-any", before this patch.
