Richard Henderson <richard.hender...@linaro.org> writes:
> On 11/18/22 05:30, Alex Bennée wrote: >> Richard Henderson <richard.hender...@linaro.org> writes: >> >>> Create a wrapper for locking/unlocking the iothread lock. >>> >>> Signed-off-by: Richard Henderson <richard.hender...@linaro.org> >>> --- >>> Cc: Paolo Bonzini <pbonz...@redhat.com> (maintainer:Main loop) >> You might want to review Paolo's comments from: >> Subject: [RFC PATCH] main-loop: introduce WITH_QEMU_IOTHREAD_LOCK >> Date: Mon, 24 Oct 2022 18:19:09 +0100 >> Message-Id: <20221024171909.434818-1-alex.ben...@linaro.org> >> So it would be worth having the WITH_QEMU_IOTHREAD_LOCK() and >> MAYBE_WITH_QEMU_IOTHREAD_LOCK() helpers for completeness. > > I don't see that (MAYBE_)WITH_QEMU_IOTHREAD_LOCK is particularly > useful in any of the cases that I converted. Fair enough - as long as they are easy enough to add later. The WITH_ forms do work nicely to wrap a particular area under lock and make things visually clear vs the LOCK_GUARD which basically holds the lock to the end of function or exit. > >> And of course the name cleanup. > > What name cleanup? Also lots of bonus points for finally renaming these functions to "*_main_thread" rather than "*_iothread" since, confusingly, iothreads (plural) are the only ones that do not and cannot take the "iothread lock". > > > r~ -- Alex Bennée
