Having an "update interrupt" function is the more common convention in QEMU device models -- it means you have one function you can call from any point where you've updated any of the state that affects whether an interrupt is generated or not.
Ok, will keept it.
For instance there's currently I think a bug where when the guest writes to the CR register and changes the value of the CR_OCIEN bit we aren't updating the state of the IRQ line. If you keep the imx_epit_update_int() function then fixing that bug is fairly straightforward: you just need to call it in the appropriate place. Without the function then the logic of "what is the IRQ line state given the current device register state" ends up dispersed across the device model code and potentially duplicated.
That bug is fixed for the next iteration of this patch set. Axel
