On Mon, 21 Nov 2022 at 14:44, Thomas Huth <th...@redhat.com> wrote: > > The logs in the gitlab-CI have a size constraint, and sometimes > we already hit this limit. The biggest part of the log then seems > to be filled by the qom-test, so we should decrease the size of > the output - which can be done easily by not printing the path > for each property, since the path has already been logged at the > beginning of each node that we handle here. > > However, if we omit the path, we should make sure to not recurse > into child nodes in between, so that it is clear to which node > each property belongs. Thus store the children and links in a > temporary list and recurse only at the end of each node, when > all properties have already been printed. > > Signed-off-by: Thomas Huth <th...@redhat.com> > --- > See e.g. here for a log that got too big: > https://gitlab.com/qemu-project/qemu/-/jobs/3355901224 > > tests/qtest/qom-test.c | 22 +++++++++++++++++++--- > 1 file changed, 19 insertions(+), 3 deletions(-)
Nice! Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>