On Fri, Dec 2, 2022 at 12:09 AM Bin Meng <bm...@tinylab.org> wrote: > > "hartid-base" and "priority-base" are zero by default. There is no > need to initialize them to zero again.
What is the defaults change though? I feel like these are worth leaving in Alistair > > Signed-off-by: Bin Meng <bm...@tinylab.org> > --- > > hw/riscv/opentitan.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/riscv/opentitan.c b/hw/riscv/opentitan.c > index be7ff1eea0..da73aa51f5 100644 > --- a/hw/riscv/opentitan.c > +++ b/hw/riscv/opentitan.c > @@ -165,10 +165,8 @@ static void lowrisc_ibex_soc_realize(DeviceState > *dev_soc, Error **errp) > > /* PLIC */ > qdev_prop_set_string(DEVICE(&s->plic), "hart-config", "M"); > - qdev_prop_set_uint32(DEVICE(&s->plic), "hartid-base", 0); > qdev_prop_set_uint32(DEVICE(&s->plic), "num-sources", 180); > qdev_prop_set_uint32(DEVICE(&s->plic), "num-priorities", 3); > - qdev_prop_set_uint32(DEVICE(&s->plic), "priority-base", 0x00); > qdev_prop_set_uint32(DEVICE(&s->plic), "pending-base", 0x1000); > qdev_prop_set_uint32(DEVICE(&s->plic), "enable-base", 0x2000); > qdev_prop_set_uint32(DEVICE(&s->plic), "enable-stride", 32); > -- > 2.34.1 > >