On Thu, 8 Dec 2022 at 09:25, Markus Armbruster <arm...@redhat.com> wrote: > > block/block-hmp-cmds.h and qemu/co-shared-resource.h use coroutine_fn > without including qemu/coroutine.h. They compile only if it's already > included from elsewhere. > > I could fix that, but pulling in qemu/coroutine.h and everything it > includes just for a macro that expands into nothing feels silly. > Instead, move the macro to qemu/osdep.h. > > Inclusions of qemu/coroutine.h just for coroutine_fn become > superfluous. Drop them. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > include/block/aio_task.h | 2 -- > include/block/block-common.h | 1 - > include/monitor/hmp.h | 1 - > include/qemu/coroutine.h | 18 +++++++----------- > include/qemu/osdep.h | 16 ++++++++++++++++ > 5 files changed, 23 insertions(+), 15 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>