On Thu, 15 Dec 2022 at 09:45, Wang, Wenchao <wenchao.w...@intel.com> wrote: > > Hi, Thomas, > > Thanks for your reply. I have attempted to follow you suggestions but it > always failed on tagging a GPG-signed tag before submitting the pull request. > I have used GPG 2.2.4 to generate a RSA4096 GPG secret key and pasted the > public key on GitHub successfully. > > $ git tag -s pull-request-hax -m 'target/i386/hax: Add XCR0 support' > error: gpg failed to sign the data > error: unable to sign the tag > > Meanwhile, could @Paolo Bonzini or @Stefan Hajnoczi help to pick the patch up > as there is only one-line change for HAX and we have verified it for all > guest launching? Thanks a lot.
Yes, please. For a single trivial patch I strongly prefer that some existing (in this case x86) maintainer takes it in their pullreq, rather than my having to deal with a pullreq submission from a new-to-the-process person. (It's extra work to check submissions from new people, which is fine if they're going to be doing them a lot in future, but for a one-off it's a waste of their time and mine.) thanks -- PMM