Richard Henderson <richard.hender...@linaro.org> writes: > On 12/16/22 13:29, Fabiano Rosas wrote: >> - /* >> - * Misaligned thumb pc is architecturally impossible. >> - * We have an assert in thumb_tr_translate_insn to verify this. >> - * Fail an incoming migrate to avoid this assert. >> - */ >> - if (!is_a64(env) && env->thumb && (env->regs[15] & 1)) { >> - return -1; >> - } >> + /* >> + * Misaligned thumb pc is architecturally impossible. >> + * We have an assert in thumb_tr_translate_insn to verify this. >> + * Fail an incoming migrate to avoid this assert. >> + */ >> + if (!is_a64(env) && env->thumb && (env->regs[15] & 1)) { >> + return -1; >> + } > > This is a sanity check rejecting malformed vmsave. While hw virt won't have > the same > assert as mentioned in the comment, it won't be happy and will raise some > sort of cpu > exception later. I think it's better to reject the bad vmload early. I > suppose we could > expand the comment to that effect, so that it doesn't appear to be wholly tcg > inspired.
I see, I'll leave it out of tcg_enabled() and update the comment. > Otherwise, > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > > > r~