On 11 January 2012 16:31, Mark Langsdorf <mark.langsd...@calxeda.com> wrote: > +static SysBusDeviceInfo armv7m_nvic_priv_info = { > + .init = armv7m_nvic_init, > + .qdev.name = "armv7m_nvic", > + .qdev.size = sizeof(nvic_state), > + .qdev.vmsd = &vmstate_nvic,
So Andreas pointed out the inconsistent spacing here and you fixed it in v8 of this patch but it's back again in v9. I mention this mostly because it indicates that you have some problem with your workflow which is causing you to lose fixes you make. In fact this is the second time that I've seen a fix you've made in one round of the patch series vanish again in a subsequent round. You need to find out what is causing this and fix it :-) You needn't bother resending this patch -- I'll just fix the space when I apply it to the arm-devs.next queue. On that basis: Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> -- PMM