"Michael S. Tsirkin" <m...@redhat.com> writes: > On Fri, Dec 09, 2022 at 02:47:57PM +0100, Markus Armbruster wrote: >> Back in 2016, we discussed[1] rules for headers, and these were >> generally liked: >> >> 1. Have a carefully curated header that's included everywhere first. We >> got that already thanks to Peter: osdep.h. >> >> 2. Headers should normally include everything they need beyond osdep.h. >> If exceptions are needed for some reason, they must be documented in >> the header. If all that's needed from a header is typedefs, put >> those into qemu/typedefs.h instead of including the header. >> >> 3. Cyclic inclusion is forbidden. > > Looks like this breaks fuzzer build: > > https://gitlab.com/mstredhat/qemu/-/jobs/3506121308
Will be fixed in v2, thanks!