On Thu, Dec 22, 2022 at 2:28 AM Daniel Henrique Barboza <dbarb...@ventanamicro.com> wrote: > > Some boards are duplicating the 'riscv_find_and_load_firmware' call > because the 32 and 64 bits images have different names. Create > a function to handle this detail instead of hardcoding it in the boards. > > Ideally we would bake this logic inside riscv_find_and_load_firmware(), > or even create a riscv_load_default_firmware(), but at this moment we > cannot infer whether the machine is running 32 or 64 bits without > accessing RISCVHartArrayState, which in turn can't be accessed via the > common code from boot.c. In the end we would exchange 'firmware_name' > for a flag with riscv_is_32bit(), which isn't much better than what we > already have today. > > Cc: Palmer Dabbelt <pal...@dabbelt.com> > Signed-off-by: Daniel Henrique Barboza <dbarb...@ventanamicro.com> > --- > hw/riscv/boot.c | 9 +++++++++ > hw/riscv/sifive_u.c | 11 ++++------- > hw/riscv/spike.c | 14 +++++--------- > hw/riscv/virt.c | 10 +++------- > include/hw/riscv/boot.h | 1 + > 5 files changed, 22 insertions(+), 23 deletions(-) >
Reviewed-by: Bin Meng <bm...@tinylab.org>
