On 30/12/22 09:58, Bin Meng wrote:
On Fri, Dec 30, 2022 at 2:21 AM Daniel Henrique Barboza
<dbarb...@ventanamicro.com> wrote:
riscv_load_kernel() and riscv_load_initrd() works under the assumption
that 'kernel_filename' and 'filename' are not NULL.
We should do the same in riscv_load_firmware()
Can be done on top IMHO.
This is currently the case since all callers of both functions are
checking for NULL before calling them. Put an assert in both to make
sure that a NULL value for both cases would be considered a bug.
Suggested-by: Alex Bennée <alex.ben...@linaro.org>
Signed-off-by: Daniel Henrique Barboza <dbarb...@ventanamicro.com>
---
hw/riscv/boot.c | 4 ++++
1 file changed, 4 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
