> -----Original Message----- > From: Alex Bennée <alex.ben...@linaro.org> > Sent: Thursday, January 5, 2023 10:43 AM > To: qemu-devel@nongnu.org; alex.ben...@gmail.com > Cc: David Hildenbrand <da...@redhat.com>; Sunil Muthuswamy > <sunil...@microsoft.com>; Aurelien Jarno <aurel...@aurel32.net>; > Michael Rolnik <mrol...@gmail.com>; Aleksandar Rikalo > <aleksandar.rik...@syrmia.com>; Greg Kurz <gr...@kaod.org>; Ilya > Leoshkevich <i...@linux.ibm.com>; Thomas Huth <th...@redhat.com>; > qemu-...@nongnu.org; Laurent Vivier <laur...@vivier.eu>; Max Filippov > <jcmvb...@gmail.com>; Yanan Wang <wangyana...@huawei.com>; Marek > Vasut <ma...@denx.de>; Stafford Horne <sho...@gmail.com>; Peter > Maydell <peter.mayd...@linaro.org>; Daniel Henrique Barboza > <danielhb...@gmail.com>; Palmer Dabbelt <pal...@dabbelt.com>; Alex > Bennée <alex.ben...@linaro.org>; Taylor Simpson > <tsimp...@quicinc.com>; Marcel Apfelbaum > <marcel.apfelb...@gmail.com>; Alexandre Iooss <erdn...@crans.org>; > Chris Wulff <crwu...@gmail.com>; Richard Henderson > <richard.hender...@linaro.org>; Eduardo Habkost > <edua...@habkost.net>; Song Gao <gaos...@loongson.cn>; Mark Cave- > Ayland <mark.cave-ayl...@ilande.co.uk>; Cédric Le Goater <c...@kaod.org>; > Artyom Tarasenko <atar4q...@gmail.com>; Paolo Bonzini > <pbonz...@redhat.com>; qemu-ri...@nongnu.org; qemu- > s3...@nongnu.org; Alistair Francis <alistair.fran...@wdc.com>; Edgar E. > Iglesias <edgar.igles...@gmail.com>; Bastian Koppelmann > <kbast...@mail.uni-paderborn.de>; Jiaxun Yang > <jiaxun.y...@flygoat.com>; Philippe Mathieu-Daudé <phi...@linaro.org>; > Bin Meng <bin.m...@windriver.com>; Mahmoud Mandour > <ma.mando...@gmail.com>; David Gibson <da...@gibson.dropbear.id.au>; > Yoshinori Sato <ys...@users.sourceforge.jp>; Xiaojuan Yang > <yangxiaoj...@loongson.cn>; qemu-...@nongnu.org > Subject: [PATCH v2 19/21] gdbstub: move register helpers into standalone > include > > These inline helpers are all used by target specific code so move them out of > the general header so we don't needlessly pollute the rest of the API with > target specific stuff. > > Note we have to include cpu.h in semihosting as it was relying on a side > effect before. > > Signed-off-by: Alex Bennée <alex.ben...@linaro.org> > > diff --git a/target/hexagon/gdbstub.c b/target/hexagon/gdbstub.c > index d152d01bfe..46083da620 100644 > --- a/target/hexagon/gdbstub.c > +++ b/target/hexagon/gdbstub.c > @@ -16,7 +16,7 @@ > */ > > #include "qemu/osdep.h" > -#include "exec/gdbstub.h" > +#include "gdbstub/helpers.h" > #include "cpu.h" > #include "internal.h"
Reviewed-by: Taylor Simpson <tsimp...@quicinc.com>