On 1/7/23 10:02, Paolo Bonzini wrote:
On 1/3/23 20:31, Stefan Hajnoczi wrote:
The other problem with this file is that it appears to
be generated differently depending on the host distro
(specifically the default value for the --libdir option).
That also would seem to nudge towards "don't commit a
generated file".
I wasn't aware of the libdir default that Peter mentioned, but the same issue would happen
for release tarballs so "do not commit it" would have to be extended to "do not ship it",
that is do everything in Python.
This in turn goes back to the reason for the buildoptions.sh approach: the path to the
Python binary is not known when "configure --help" prints the help message. If the user
does not have a python3 or meson binary in the path, requiring "configure --meson=...
--help" or "configure --python=... --help" is not hideous I guess, but not pretty either.
I think an extremely early error message for missing python (and pointer to --python) is
perfectly reasonable. I imagine it would be very rare, a case of forgetting to install
all of the build dependencies into a fresh container.
r~
