On 13.01.2012, at 17:08, Jan Kiszka wrote: > On 2012-01-13 16:57, Andreas Färber wrote: >> Am 13.01.2012 10:21, schrieb Jan Kiszka: >>> On 2012-01-13 04:09, Andreas Färber wrote: >>>> + isa_bus = DO_UPCAST(ISABus, qbus, qdev_get_child_bus(&pci->qdev, >>>> "isa.0")); >>>> + >>>> + i8259 = isa_bus->irqs; >>> >>> I think this is unneeded. >> >> The problem here was that isa_get_irq() needs an ISADevice*, not just >> the ISABus*, so I had to access ->irqs directly at this point. > > Which is a hack that should not be merged. > >> >> Some of the later ISA devices are optional, others will be moved to the >> pc87312. The i8042 might be an option if we really have to. >> >>> You only access i8259[8] later on for >>> initializing the m48t59. >> >> And immediately following your quote i8259[9] and i8259[11] for the host >> bridge. > > I was looking at upstream. Which patch is this?
The patch you were commenting on :) Alex