From: Daniel P. Berrangé <berra...@redhat.com> We've been very gradually adding G_GNUC_PRINTF annotations to functions over years. This has been useful in detecting certain malformed printf strings, or cases where we pass user data as the printf format which is a potential security flaw.
Given the inherant memory corruption danger in use of format strings vs mis-matched variadic arguments, it is worth applying G_GNUC_PRINTF to all functions using printf, even if we know they are safe. The compilers can reasonably reliably identify such places with the -Wsuggest-attribute=format / -Wmissing-format-attribute flags. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> Message-Id: <20221219130205.687815-7-berra...@redhat.com> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/configure index 6f5e77a71361..203b957a045f 100755 --- a/configure +++ b/configure @@ -1183,6 +1183,8 @@ add_to warn_flags -Wnested-externs add_to warn_flags -Wendif-labels add_to warn_flags -Wexpansion-to-defined add_to warn_flags -Wimplicit-fallthrough=2 +add_to warn_flags -Wsuggest-attribute=format +add_to warn_flags -Wmissing-format-attribute nowarn_flags= add_to nowarn_flags -Wno-initializer-overrides -- 2.38.1
