On Tue, 10 Jan 2023 at 16:45, Philippe Mathieu-Daudé <phi...@linaro.org> wrote: > > Replace the ARMCPU field in DigicState by a reference to > an allocated ARMCPU. Instead of initializing the field > with object_initialize(), allocate it with object_new(). > > As we don't access ARMCPU internal fields or size, we can > move digic.c from arm_ss[] to the more generic softmmu_ss[].
I'm not really a fan of this, because it moves away from a standard coding pattern we've been using for new QOM 'container' devices, where all the sub-components of the device are structs embedded in the device's own struct. This is as opposed to the old style which tended to use "allocate memory for the sub-component and have pointers to it". It means the CPU object is now being treated differently from all the timers, UARTs, etc. thanks -- PMM