On Tue, Jan 10, 2023 at 03:13:18PM +0000, Peter Maydell wrote: > Meson supports an "uninstall", so we can easily allow it to work by > not suppressing the forwarding of it from Make to meson. > > We originally suppressed this because Meson's 'uninstall' has a hole > in it: it will remove everything that is installed by a mechanism > meson knows about, but not things installed by "custom install > scripts", and there is no "custom uninstall script" mechanism. > > For QEMU, though, the only thing that was being installed by a custom > install script was the LC_MESSAGES files handled by Meson's i18n > module, and that code was fixed in Meson commit 487d45c1e5bfff0fbdb4, > which is present in Meson 0.60.0 and later. Since we already require > a Meson version newer than that, we're now safe to enable > 'uninstall', as it will now correctly uninstall everything that was > installed. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/109 > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
