Am 16.01.23 um 10:03 schrieb Daniel P. Berrangé:
On Sun, Dec 18, 2022 at 06:15:36PM +0100, Volker Rümelin wrote:
Replace audio_calloc() with the equivalent g_new0().
With a n_structs argument >= 1, g_new0() never returns NULL.
Also remove the unnecessary NULL checks.
Signed-off-by: Volker Rümelin<vr_q...@t-online.de>
---
audio/audio_template.h | 23 ++++++-----------------
1 file changed, 6 insertions(+), 17 deletions(-)
diff --git a/audio/audio_template.h b/audio/audio_template.h
index 5f51ef26b2..9c600448fb 100644
--- a/audio/audio_template.h
+++ b/audio/audio_template.h
@@ -129,12 +129,7 @@ static int glue (audio_pcm_sw_alloc_resources_, TYPE) (SW
*sw)
return -1;
}
- sw->buf = audio_calloc(__func__, samples, sizeof(struct st_sample));
- if (!sw->buf) {
- dolog ("Could not allocate buffer for `%s' (%d samples)\n",
- SW_NAME (sw), samples);
- return -1;
- }
+ sw->buf = g_new0(st_sample, samples);
"samples" is a signed integer, and audio_calloc would check for
it being negative and raise an error. It would also check for
samples being zero. I think we still need both these checks,
as a negative value of samples when cast to size_t would be a
huge size.
Hi Daniel,
patch 01/11 ("audio: log unimplemented audio device sample rates") takes
care of samples == 0. But you are right, I didn't consider samples < 0.
I will send a version 2 patch within the next few days.
With best regards,
Volker
With regards,
Daniel