On Wed, Jan 25, 2023 at 09:24:24AM +0000, Dr. David Alan Gilbert wrote:
> > > > static void *file_ram_alloc(RAMBlock *block,
> > > > int fd,
> > > > bool truncate,
> > > > off_t offset,
> > > > Error **errp)
> > > > {
> > > > - uint32_t qemu_map_flags;
> > > > void *area;
> > > >
> > > > /* Remember the offset just in case we'll need to map the range
> > > > again */
> > >
> > > Note that this comment is now wrong; you need to always set that for the
> > > map call.
> >
> > This line is added in patch 7. After this patch, a ramblock should always
> > be mapped with ramblock_file_map(), so it keeps being true?
>
> With ramblock_file_map() it's not a 'just in case' any more though is
> it? This value always goes through the block-> now?
Ah yes.. Since the comment is not extremely informative, instead of
changing it, I can drop it in the previous patch when introduced.
--
Peter Xu
