Peter Xu <[email protected]> wrote: > We do proper page size alignment for file backed mmap()s for ramblocks. > Even if it's as simple as that, cache the value because it'll be used in > multiple places. > > Since at it, drop size for file_ram_alloc() and just use max_length because > that's always true for file-backed ramblocks. > > Signed-off-by: Peter Xu <[email protected]>
Reviewed-by: Juan Quintela <[email protected]> > @@ -2100,7 +2100,7 @@ RAMBlock *qemu_ram_alloc_from_fd(ram_addr_t size, > MemoryRegion *mr, > new_block->used_length = size; > new_block->max_length = size; > new_block->flags = ram_flags; > - new_block->host = file_ram_alloc(new_block, size, fd, readonly, > + new_block->host = file_ram_alloc(new_block, fd, readonly, > !file_size, offset, errp); > if (!new_block->host) { > g_free(new_block); Passing "size" in three places, not bad at all O:-)
