On 8/2/23 11:53, Markus Armbruster wrote:
Philippe Mathieu-Daudé <phi...@linaro.org> writes:

On 3/2/23 09:45, Markus Armbruster wrote:
monitor/misc.h has static add_completion_option().  It's useful
elsewhere in the monitor.  Since it's not monitor-specific, move it to
util/readline.c renamed to readline_add_completion_of(), and put it to
use.

52f50b1e9f8fd410d4293a211d549ec61b902728 is the first bad commit

This commit broke monitor autocomplete feature.

Before:

(qemu) <tab>
?                                announce_self
balloon                          block_job_cancel
block_job_complete               block_job_pause
block_job_resume                 block_job_set_speed
[...]

After:

(qemu) <tab>
[no autocomplete]

I'll look into it.  Thanks!

This fixed it:
https://lore.kernel.org/qemu-devel/20230207045241.8843-1-dongli.zh...@oracle.com/


Reply via email to