Thanks for pointing that out. I'll send another version to fix that.
On Tue, Feb 7, 2023 at 11:48 PM Philippe Mathieu-Daudé <phi...@linaro.org>
wrote:
> On 7/2/23 20:45, Hao Wu wrote:
> > Nuvoton's PSPI is a general purpose SPI module which enables
> > connections to SPI-based peripheral devices.
> >
> > Signed-off-by: Hao Wu <wuhao...@google.com>
> > Reviewed-by: Chris Rauer <cra...@google.com>
> > Reviewed-by: Philippe Mathieu-Daude <phi...@linaro.org>
> > ---
> > MAINTAINERS | 6 +-
> > hw/ssi/meson.build | 2 +-
> > hw/ssi/npcm_pspi.c | 221 +++++++++++++++++++++++++++++++++++++
> > hw/ssi/trace-events | 5 +
> > include/hw/ssi/npcm_pspi.h | 53 +++++++++
> > 5 files changed, 283 insertions(+), 4 deletions(-)
> > create mode 100644 hw/ssi/npcm_pspi.c
> > create mode 100644 include/hw/ssi/npcm_pspi.h
>
>
> > +static const MemoryRegionOps npcm_pspi_ctrl_ops = {
> > + .read = npcm_pspi_ctrl_read,
> > + .write = npcm_pspi_ctrl_write,
> > + .endianness = DEVICE_LITTLE_ENDIAN,
> > + .valid = {
> > + .min_access_size = 1,
> > + .max_access_size = 4,
>
> You said in v1 "The datasheet suggests it's either 8-bit or
> 16-bit accesses.", so we want max_access_size = 2 here, right?
>
> > + .unaligned = false,
> > + },
> > + .impl = {
> > + .min_access_size = 2,
> > + .max_access_size = 2,
> > + .unaligned = false,
> > + },
> > +};
>
>
>
