On Thu, Feb 9, 2023 at 10:56 AM Thomas Huth <th...@redhat.com> wrote: > > On 09/02/2023 16.40, John Snow wrote: > > This is just a proof-of-concept patch, as these files are lcitool > > generated. The real fix will involve updating the lcitool configuration > > and updating these files that way. > > I think it would be good to have a RFC or DONOTMERGE in the patch title, so > that it is clear right from the start that this should not get merged.
Apologies. I just assumed there'd be no risk of this passing review :) If there's any point in me respinning this with the proof-of-concept again, I'll add a DO-NOT-MERGE tag. > > > Note that this requires OpenSuSE Leap 15.3; 15.2 won't cut it. > > Looking at https://en.wikipedia.org/wiki/OpenSUSE#Version_history it seems > like even 15.3 is EOL already, so I think we can switch to 15.4 immediately. > Noted. Some of the patches in this series are a bit old, admittedly, so I'll re-review these requirements. I'm hoping to hear from Dan/Alex on the subject of coverage, because I don't really know what our current strategy is or what our coverage ought to be. If CI minutes were infinitely free, I'd suggest we test both CentOS 8 and 9 simultaneously, alongside with every currently supported OpenSuSE version, but I imagine that's not really truly on the table. I imagine we want to have a mixture of "cutting edge" with "oldest we still support" to try and cover the spread of likely scenarios, but I am not sure what the strategies for which to keep at which versions are. > Thomas >