John Snow <js...@redhat.com> writes: > Primarily, this reduces a nesting level of a particularly long > block. It's mostly code movement, but a new docstring is created. > > It also has the effect of creating a fairly convenient "catch point" in > check_exprs for exception handling without making the nesting level even > worse.
I don't get this sentence, I'm afraid. It could tip the balance... > Signed-off-by: John Snow <js...@redhat.com> > > --- > > This patch was originally written as part of my effort to factor out > QAPISourceInfo from this file by having expr.py raise a simple > exception, then catch and wrap it at the higher level. > > This series doesn't do that anymore, but reducing the nesting level > still seemed subjectively nice. It's not crucial. Is reducing the nesting level worth sacrificing git-blame? If we decide it is: there are two "Checked in check_exprs" comments in need of an update. > Signed-off-by: John Snow <js...@redhat.com> Harmless accident :)
