On Fri, Feb 10, 2023 at 10:28:42AM -0500, John Snow wrote: > > > python= > > > +first_python= > > > explicit_python=no > > > -for binary in "${PYTHON-python3}" python > > > +# A bare 'python' is traditionally python 2.x, but some distros > > > +# have it as python 3.x, so check in both places. > > > +for binary in "${PYTHON-python3}" python python3.{11..6} > > > > This is not available in e.g. dash, so we need to use {11,10,9,8,7,6}. > > Just a nit, I can fix it myself.
Shoot - I didn't notice v2 before I reviewed v1, where I pointed out the same problem. But note that dash doesn't understand ANY brace expansion; {11,10,9} is no better than {11..9}. The list is also not testing python3 when $PYTHON is set. See my suggestion for fixing that in my mail on v1. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org