Re: [PATCH 1/9] bsd-user: Don't truncate the return value from freebsd_syscall

[Richard Henderson]

On 2/10/23 13:18, Warner Losh wrote:

From: Doug Rabson <d...@rabson.org>

System call return values on FreeBSD are in a register (which is spelled
api_long in qemu). This was being assigned into an int variable which

s/api/abi/

causes problems for 64bit targets.

Resolves: https://github.com/qemu-bsd-user/qemu-bsd-user/issues/40
Signed-off-by: Doug Rabson <d...@rabson.org>
Reviewed-by: Warner Losh <i...@bsdimp.com>
[ Edited commit message for upstreaming into qemu-project ]
Signed-off-by: Warner Losh <i...@bsdimp.com>
---
  bsd-user/freebsd/os-syscall.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

r~

diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c
index 57996cad8ae..b4a663fc021 100644
--- a/bsd-user/freebsd/os-syscall.c
+++ b/bsd-user/freebsd/os-syscall.c
@@ -512,7 +512,7 @@ abi_long do_freebsd_syscall(void *cpu_env, int num, 
abi_long arg1,
                              abi_long arg8)
  {
      CPUState *cpu = env_cpu(cpu_env);
-    int ret;
+    abi_long ret;

trace_guest_user_syscall(cpu, num, arg1, arg2, arg3, arg4, arg5, arg6, arg7, arg8);

      if (do_strace) {