On Mon, Feb 13, 2023 at 02:27:18PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Mon, 13 Feb 2023 14:27:18 +0100
> From: Philippe Mathieu-Daudé <phi...@linaro.org>
> Subject: Re: [RFC 33/52] i386: Rename init_topo_info() to
> init_apic_topo_info()
>
> On 13/2/23 10:50, Zhao Liu wrote:
> > From: Zhao Liu <zhao1....@intel.com>
> >
> > Rename init_topo_info() to init_apic_topo_info() to adapt
> > X86ApicidTopoInfo.
> >
> > Co-Developed-by: Zhuocheng Ding <zhuocheng.d...@intel.com>
> > Signed-off-by: Zhuocheng Ding <zhuocheng.d...@intel.com>
> > Signed-off-by: Zhao Liu <zhao1....@intel.com>
> > ---
> > hw/i386/x86.c | 12 ++++++------
> > include/hw/i386/x86.h | 3 ++-
> > 2 files changed, 8 insertions(+), 7 deletions(-)
>
>
> > diff --git a/include/hw/i386/x86.h b/include/hw/i386/x86.h
> > index ac6f1e4a74af..d84f7717900c 100644
> > --- a/include/hw/i386/x86.h
> > +++ b/include/hw/i386/x86.h
> > @@ -98,7 +98,8 @@ struct X86MachineState {
> > #define TYPE_X86_MACHINE MACHINE_TYPE_NAME("x86")
> > OBJECT_DECLARE_TYPE(X86MachineState, X86MachineClass, X86_MACHINE)
> > -void init_topo_info(X86ApicidTopoInfo *topo_info, const X86MachineState
> > *x86ms);
> > +void init_apicid_topo_info(X86ApicidTopoInfo *topo_info,
> > + const X86MachineState *x86ms);
>
> Maybe s/init_apicid_topo_info/init_apic_topo_info/?
>
> Otherwise,
>
> Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
>
Will remove the "id" suffix. Thanks!
Zhao
