Re: [PATCH 07/18] target/riscv: Simplify {read,write}_pmpcfg() a little bit

[LIU Zhiwei]

On 2023/2/14 2:02, Bin Meng wrote:

Use the register index that has already been calculated in the
pmpcfg_csr_{read,write} call.

Signed-off-by: Bin Meng <bm...@tinylab.org>
---

  target/riscv/csr.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/riscv/csr.c b/target/riscv/csr.c
index 8bbc75cbfa..da3b770894 100644
--- a/target/riscv/csr.c
+++ b/target/riscv/csr.c
@@ -3363,7 +3363,7 @@ static RISCVException read_pmpcfg(CPURISCVState *env, int 
csrno,
      if (!check_pmp_reg_index(env, reg_index)) {
          return RISCV_EXCP_ILLEGAL_INST;
      }
-    *val = pmpcfg_csr_read(env, csrno - CSR_PMPCFG0);
+    *val = pmpcfg_csr_read(env, reg_index);
      return RISCV_EXCP_NONE;
  }

@@ -3375,7 +3375,7 @@ static RISCVException write_pmpcfg(CPURISCVState *env, int csrno,

      if (!check_pmp_reg_index(env, reg_index)) {
          return RISCV_EXCP_ILLEGAL_INST;
      }
-    pmpcfg_csr_write(env, csrno - CSR_PMPCFG0, val);
+    pmpcfg_csr_write(env, reg_index, val);

Reviewed-by: LIU Zhiwei <zhiwei_...@linux.alibaba.com>

Zhiwei

      return RISCV_EXCP_NONE;
  }