On Mon, 23 Jan 2012 11:05:25 -0600, Anthony Liguori <aligu...@us.ibm.com> wrote: > On 01/23/2012 07:02 AM, Aneesh Kumar K.V wrote: > > > > > > The following changes since commit 8c4ec5c0269bda18bb777a64b2008088d1c632dc: > > > > pxa2xx_keypad: fix unbalanced parenthesis. (2012-01-17 02:14:42 +0100) > > > > are available in the git repository at: > > > > git://github.com/kvaneesh/QEMU.git for-upstream > > > > for you to fetch changes up to 0700a73cfe166100cb59e28aad2c1fc5e4e952cb: > > > > hw/9pfs: Update MAINTAINERS file (2012-01-23 12:26:54 +0530) > > CC libhw64/9pfs/virtio-9p-local.o > cc1: warnings being treated as errors > /home/anthony/git/qemu/hw/9pfs/virtio-9p-local.c: In function > ‘local_set_mapped_file_attr’: > /home/anthony/git/qemu/hw/9pfs/virtio-9p-local.c:153:9: error: ‘uid’ may be > used > uninitialized in this function > /home/anthony/git/qemu/hw/9pfs/virtio-9p-local.c:153:14: error: ‘gid’ may be > used uninitialized in this function > /home/anthony/git/qemu/hw/9pfs/virtio-9p-local.c:153:19: error: ‘mode’ may be > used uninitialized in this function > /home/anthony/git/qemu/hw/9pfs/virtio-9p-local.c:153:25: error: ‘rdev’ may be > used uninitialized in this function > make[1]: *** [9pfs/virtio-9p-local.o] Error 1 > make: *** [subdir-libhw64] Error 2 > > I see a lot of build breakages come into through this tree. I understand > that > GCC can be fickle with -Werror but there's an easy way to solve this. > > Please get your tree added to buildbot and make sure there's a successful > buildbot run before you do a pull request.
I will do this > > Alternatively, setup multiple VMs to build test yourself. But please do > something to check the build a bit more rigorously before sending future PULL > requests. > I actually do build test on ubuntu 11.10, fedora 15, rhel5.7 before pull request. That usually catch most of the errors like above. -aneesh
