Hi Michael, Thanks for reviewing this on a weekend!
On 26/2/23 19:51, Michael S. Tsirkin wrote: > On Sun, Feb 26, 2023 at 01:58:10AM +0000, Damien Zammit wrote: >> case 0: >> - out = (d >= s->count); >> - break; > > > I think you need something like > /* FALLTHRU */ > here otherwise some gcc versions will warn. > >> case 1: >> - out = (d < s->count); >> + out = (d >= s->count); It seems that there are quite a number of these consecutive fallthrough cases without /* FALLTHRU */ in i8254_common.c Can these be fixed in a separate patch? Damien
