在 2023/2/26 上午2:38, Richard Henderson 写道:
On 2/25/23 00:22, Daniel Henrique Barboza wrote:
Richard,

Not sure if I forgot or missed something but this patch breaks my build as follows:

$  make -j
   GIT     ui/keycodemapdb tests/fp/berkeley-testfloat-3 tests/fp/berkeley-softfloat-3 dtc
[1/885] Generating trace/trace-hw_hyperv.c with a custom command
FAILED: trace/trace-hw_hyperv.c
/usr/bin/python3 ../scripts/tracetool.py --backend=log --group=hw_hyperv --format=c /home/danielhb/work/qemu/hw/hyperv/trace-events trace/trace-hw_hyperv.c
Traceback (most recent call last):
   File "/home/danielhb/work/qemu/build/../scripts/tracetool.py", line 19, in <module>
     from tracetool import error_write, out, out_open
   File "/home/danielhb/work/qemu/scripts/tracetool/__init__.py", line 21, in <module>
     import tracetool.transform
ModuleNotFoundError: No module named 'tracetool.transform'


I saw the same thing on gitlab, but not on my laptop.  Weird.

I always get this things.


[26/2330] Generating trace/trace-hw_block.h with a custom command
FAILED: trace/trace-hw_block.h
/usr/bin/python3 ../scripts/tracetool.py --backend=log --group=hw_block --format=h /root/qemu/hw/block/trace-events trace/trace-hw_block.h
Traceback (most recent call last):
  File "/root/qemu/build/../scripts/tracetool.py", line 19, in <module>
    from tracetool import error_write, out, out_open
  File "/root/qemu/scripts/tracetool/__init__.py", line 21, in <module>
    import tracetool.transform
ModuleNotFoundError: No module named 'tracetool.transform'

It seems that tracetool.py is still referring transform. This fixes the build
for me:

$ git diff
diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py
index 5393c7fc5c..c361815bc1 100644
--- a/scripts/tracetool/__init__.py
+++ b/scripts/tracetool/__init__.py
@@ -18,7 +18,6 @@

  import tracetool.format
  import tracetool.backend
-import tracetool.transform

I also removed some code below that used these symbols; they themselves appear to be unused.


r~


Reply via email to