Re: [RFC PATCH 5/5] arm/virt: provide virtualization extensions to the guest

[Richard Henderson]

On 2/27/23 06:37, Miguel Luis wrote:

-    if (vms->virt && (kvm_enabled() || hvf_enabled())) {
+    if (vms->virt && (kvm_enabled() || hvf_enabled())
+        && !kvm_arm_el2_supported()) {

The ordering of the tests isn't right -- shouldn't test kvm_arm_* for hvf.

    virt && ((kvm && !kvm_el2) || hvf)


r~