Hi Marc-André, Thanks for reviewing the series.
On Mon, Feb 27, 2023, at 1:16 AM, Marc-André Lureau wrote: > Hi > > On Fri, Feb 24, 2023 at 8:31 AM Daniel Xu <d...@dxuuu.xyz> wrote: >> >> It looks like qga's working directory is in a tempdir. So the relative >> path that the test case gives qga through the QGA_OS_RELEASE= >> env variable does not resolve correctly. >> >> Fix by doing a poor man's path canonicalization of the test data file. >> >> Note we cannot use g_canonicalize_filename() b/c that helper was only >> introduced in glib 2.58 and the current GLIB_VERSION_MAX_ALLOWED is >> pinned to 2.56. >> >> Signed-off-by: Daniel Xu <d...@dxuuu.xyz> > > This breaks "meson test test-qga" for me. How do you run the tests? Ah, thanks for the hint. I was running the qga tests in build/ with: $ ./tests/unit/test-qga Using meson to drive the tests fixed it for me. I will drop this patch. [...] Thanks, Daniel