On Fri, Mar 03, 2023 at 01:47:40PM +0100, Thomas Huth wrote: > On 01/03/2023 12.00, Juan Quintela wrote: > > Linux keyring support is protected by CONFIG_KEYUTILS. > > Use CONFIG_SECRET_KEYRING. > > > > Signed-off-by: Juan Quintela <quint...@redhat.com> > > > > --- > > > > Previous version of this patch changed the meson build rules. > > Daniel told me that the proper fix was to change the #ifdef test. > > --- > > tests/unit/test-crypto-secret.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > This seems to cause failures in the CI: > > https://gitlab.com/thuth/qemu/-/jobs/3870672310#L1443 > https://gitlab.com/thuth/qemu/-/jobs/3870672331#L2353 > > ../tests/unit/test-crypto-secret.c:29:10: fatal error: keyutils.h: No such > file or directory > 29 | #include <keyutils.h> > | ^~~~~~~~~~~~ > compilation terminated.
Hmm, so we actually have to test for both #ifdefs then With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
