On Mon, Mar 13, 2023 at 11:57:52AM +0100, Philippe Mathieu-Daudé wrote: > On 8/3/23 02:12, Michael S. Tsirkin wrote: > > From: Igor Mammedov <imamm...@redhat.com> > > > > expected changes: > > Basically adds devices present on root bus in form: > > Device (SXX) > > { > > Name (_ADR, 0xYYYYYYYY) // _ADR: Address > > } > > > > On top of that For q35.noacpihp, all ACPI PCI hotplug > > AML is removed and _OSC get native hotplug enabled: > > > > CreateDWordField (Arg3, 0x04, CDW2) > > CreateDWordField (Arg3, 0x08, CDW3) > > Local0 = CDW3 /* \_SB_.PCI0._OSC.CDW3 */ > > - Local0 &= 0x1E > > + Local0 &= 0x1F > > If ((Arg1 != One)) > > { > > CDW1 |= 0x08 > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > > Message-Id: <20230302161543.286002-5-imamm...@redhat.com> > > Reviewed-by: Michael S. Tsirkin <m...@redhat.com> > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > > Reviewed-by: Michael S. Tsirkin <m...@redhat.com> > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > > Reviewed-by: Michael S. Tsirkin <m...@redhat.com> > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > > Reviewed-by: Michael S. Tsirkin <m...@redhat.com> > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > > Reviewed-by: Michael S. Tsirkin <m...@redhat.com> > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > > Reviewed-by: Michael S. Tsirkin <m...@redhat.com> > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > > Reviewed-by: Michael S. Tsirkin <m...@redhat.com> > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > > Better safe than sorry! :P
Oh. I don't know how that happened :( > > --- > > tests/qtest/bios-tables-test-allowed-diff.h | 2 -- > > tests/data/acpi/pc/DSDT.hpbrroot | Bin 3081 -> 3115 bytes > > tests/data/acpi/q35/DSDT.noacpihp | Bin 8252 -> 7932 bytes > > 3 files changed, 2 deletions(-)