Per MST in [*]: "Calling pci_add_capability when VM is running is likely to confuse guests". Ensure this can't happen by asserting pci_add_capability() is never called after a PCI device is realized.
[*] https://lore.kernel.org/qemu-devel/20230308071628-mutt-send-email-...@kernel.org/ Based-on: <20230313153031.86107-1-phi...@linaro.org> "hw/i386/amd_iommu: Orphanize & QDev cleanups" Philippe Mathieu-Daudé (4): hw/pci/msi: Fix debug format string hw/pci/msi: Ensure msi_init() is called before device is realized hw/pci: Add sanity check in pci_find_space() hw/pci: Ensure pci_add_capability() is called before device is realized hw/pci/msi.c | 4 +++- hw/pci/pci.c | 5 ++++- 2 files changed, 7 insertions(+), 2 deletions(-) -- 2.38.1