On 01/27/2012 03:38 AM, Andreas Färber wrote:
Am 27.01.2012 07:23, schrieb Stefan Hajnoczi:
On Tue, Jan 24, 2012 at 06:17:36PM +0100, Andreas Färber wrote:
From: Andreas Färber<andreas.faer...@web.de>
VMState supports the type bool but qdev instead supports bit, backed by
uint32_t. Therefore let's add DEFINE_PROP_BOOL() and qdev_prop_set_bool().
bool by definition is either true or false. Should the need arise to
parse yes/no, on/off, 1/0 or whatever as well, we can still add that at
a later point in time.
Signed-off-by: Andreas Färber<andreas.faer...@web.de>
Cc: Juan Quintela<quint...@redhat.com>
Cc: Markus Armbruster<arm...@redhat.com>
Cc: Jan Kiszka<jan.kis...@siemens.com>
Cc: Vasilis Liaskovitis<vasilis.liaskovi...@profitbricks.com>
---
v5 -> v6:
Please merge through a qemu.git committer. v6 and discussion means this
isn't trivial.
Unfortunately that hasn't happened for half a year though. Generally no
qemu.git committer seems to care about cherry-picking useful
infrastructures from bigger series even once discussions are resolved.
So... why are we introducing a type that's not being used anywhere?
Are you planning to use this type somewhere or is this purely speculative?
Regards,
Anthony Liguori
And for the record, it's net v3 as shown in the part you snipped.
Vasilis, unless Jan or someone has further nitpicks, just prepend my v8
to your series and reuse its DEFINE_PROP_BOOL().
Andreas
