Hi Marco, (+Python experts)
On 13/3/23 18:25, Marco Liebel wrote:
Replace python 2 format string with f-strings Signed-off-by: Marco Liebel <quic_mlie...@quicinc.com> --- target/hexagon/gen_helper_funcs.py | 54 ++-- target/hexagon/gen_helper_protos.py | 10 +- target/hexagon/gen_idef_parser_funcs.py | 8 +- target/hexagon/gen_op_attribs.py | 4 +- target/hexagon/gen_op_regs.py | 10 +- target/hexagon/gen_opcodes_def.py | 2 +- target/hexagon/gen_printinsn.py | 14 +- target/hexagon/gen_shortcode.py | 2 +- target/hexagon/gen_tcg_func_table.py | 2 +- target/hexagon/gen_tcg_funcs.py | 317 +++++++++++------------- target/hexagon/hex_common.py | 4 +- 11 files changed, 198 insertions(+), 229 deletions(-)
These files use a mix of ', " and '''... Since you are modifying them, it would be nice to unify. I'm not sure there is a recommended style; matter of taste, I find the single quote (') less aggressive, then escaping it using ", and keeping ''' for multi-lines strings.